Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IIS support to MOI 0.9.14. #299

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Update IIS support to MOI 0.9.14. #299

merged 4 commits into from
Jul 1, 2020

Conversation

dourouc05
Copy link
Collaborator

@dourouc05 dourouc05 commented May 20, 2020

jump-dev/MathOptInterface.jl#1056 is merged and will be included in the next MOI release.

Several return codes are not yet in MOI, though. Should they be included in MOI?

@dourouc05
Copy link
Collaborator Author

dourouc05 commented May 28, 2020

Based on jump-dev/MathOptInterface.jl#1091, I used NO_CONFLICT_FOUND when CPLEX has aborted.

Is it good enough to be merged? (Once MOI 0.9.14 is tagged.)

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this makes much more sense.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as for the Gurobi PR

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dourouc05
Copy link
Collaborator Author

With MOI 0.9.14 being tagged, maybe this could get merged?

@dourouc05 dourouc05 requested a review from odow June 21, 2020 20:46
@odow
Copy link
Member

odow commented Jun 22, 2020

Ditto on the screenshot showing tests passing.

@dourouc05
Copy link
Collaborator Author

There's a lot of noise in the output, here is the output in two parts:

image
image

@blegat blegat merged commit 02d4ef5 into jump-dev:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants