Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some low_hanging_fruit #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Zij-IT
Copy link

@Zij-IT Zij-IT commented Apr 14, 2023

Saw your post on Reddit and just wanted to do a little bit to help out. Here are some random changes that were mostly inspired by my good friend clippy::pedantic!

None of these are behavioral changes, but just swapping some code with some other equivalent code.

@Almeida-a
Copy link
Contributor

Almeida-a commented Apr 23, 2023

I have locally merged/updated your fork branch with the latest changes.
@Zij-IT Can you give me write permission for your branch?

@Zij-IT
Copy link
Author

Zij-IT commented Apr 23, 2023

If I am didn't mess it up you should now have write access to the fork!

@Almeida-a
Copy link
Contributor

I wasn't able to, sorry. Might be me, but this is the error when I tried git push zij-it HEAD:refactoring/low_hanging_fruit:

➜  swapvec git:(ede9f62) git push zij-it HEAD:refactoring/low_hanging_fruit
remote: Permission to Zij-IT/swapvec.git denied to Almeida-a.
fatal: unable to access 'https://github.com/Zij-IT/swapvec.git/': The requested URL returned error: 403

@julianbuettner
Copy link
Owner

The codebase changed pretty much, so I am unsure how I feel about resolving the conflicts.
I also followed your advice and got some inspiration by clippy.
So maybe it makes sense to re-do the deltas where it makes sense and re-open this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants