Use a different version number for the LS and SSP #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
reviewed
May 24, 2024
| @@ -229,10 +229,11 @@ function getstore(ssi::SymbolServerInstance, environment_path::AbstractString, p | |||
| # 1.11 introduces the --compiled-modules=existing option, which should be much faster than no | |||
| # as of 2023-11-09, loading Pkg with --compiled-modules=no also changes something with the | |||
| # active project, which breaks the server.jl script | |||
| p = if VERSION > v"1.11-" | |||
| open(pipeline(Cmd(`$jl_cmd --code-coverage=$(use_code_coverage==0 ? "none" : "user") --startup-file=no --compiled-modules=existing --history-file=no --project=$environment_path $server_script $(ssi.store_path) $pipename`, env=env_to_use), stderr=stderr), read=true, write=true) | |||
| symbol_server_julia_version = VersionNumber(readchomp(Cmd(`$(ssi.julia_exe_path) --startup-file=no --history-file=no -e "println(VERSION)"`))) | |||
There was a problem hiding this comment.
Can we make this julia -v instead? Will require a bit of custom parsing, but should still be more robust I think?
There was a problem hiding this comment.
And faster... I was just not sure whether that format of that is guaranteed to stay stable? But I guess we can deal with that if it changes.
I'll change it to julia -v once I've got the whole thing working end-to-end, need to get this interdependency chaos I have locally right now sorted out first ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
For every PR, please check the following: