Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove limit on type names #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove limit on type names #219

wants to merge 1 commit into from

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Apr 13, 2021

Store full names of DataTypes. This was disable previously as it slows caching but this should be reversed if we're moving to the cloud approach.

For every PR, please check the following:

@ZacLN ZacLN added this to the Next Patch milestone Apr 13, 2021
@ZacLN ZacLN self-assigned this Apr 13, 2021
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
@davidanthoff
Copy link
Member

Needs a merge conflict resolution.

Does this affect our cache store? If so, we need to cycle this in with a cache store version update, right? So v1.2 would be an excellent vehicle for that because we are updating the cache version for that already.

Also, if this does change things that are stored in the cache, we need to update our cloud computed/cached files as well with that? I.e. reindex everything?

@davidanthoff davidanthoff modified the milestones: Next Patch, Next Minor May 12, 2021
@davidanthoff davidanthoff added the enhancement New feature or request label May 12, 2021
@ZacLN
Copy link
Contributor Author

ZacLN commented May 12, 2021

This does both (so needs new local cache store version + recaching on cloud). It adds a computational cost so my intention had been to merge it at the same time as we disable local caching - is that v1.2?

@davidanthoff davidanthoff modified the milestones: Next Minor, Backlog May 13, 2021
@davidanthoff
Copy link
Member

No, that won't be 1.2, so I removed it from that milestone for now.

@davidanthoff
Copy link
Member

@ZacLN Now that we are doing cloud indexing, should we do this?

@ZacLN
Copy link
Contributor Author

ZacLN commented Jul 21, 2021

Yep let's do it

@davidanthoff
Copy link
Member

@ZacLN Alright, just needs a merge resolve!

@davidanthoff davidanthoff removed this from the Backlog milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants