-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry indexer #202
Add registry indexer #202
Conversation
…bolServer.jl into registryindexer
…bolServer.jl into registryindexer
I'm not sure of the benefits of changing how we store the caches for Base/Core at the moment outweigh the costs (i.e. within the SymbolServer module, cached as part of the compilation process). Loading from disc would be slower. Arguments for doing this would include running type inference on all methods which is almost certianly too time consuming to be the default option for most users. I can see the possibility in the future of wanting to use SymbolServer loaded in a vXX Julia process as part of an environment representing Julia vYY, but we're not there yet. We also have the option of caching the stdlibs alongside Base/Core in the SymbolServer module. |
|
||
# Get the symbols | ||
env = getenvtree([current_package_name]) | ||
symbols(env, m) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when #203 is merged to master (and the commit pulled across to here) this should be changed to symbols(env, m, get_return_type = true)
…bolServer.jl into registryindexer
Ah, great, so we can skip that for now!
Agreed.
The downside of that is probably that during precompile we would now precompile all the stdlibs, right? But maybe the best strategy for now to just get all of this out, right? |
I'm going to merge this as is, given that it can't break anything. And then we can iterate with more improvements in future PRs. |
Very WIP. Some things that still need to be done: