Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localregistry input option #38

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

lukasgrunwald
Copy link
Contributor

Implements and resolves #37 .
Option to add local registries to build process by specifying their url (https). Authentication to the repos via specified GitHub token (default: User Github Token)

Snippet example for using the new flags, that adds two private Registries CondMatRegistry.git and HolyLabRegistry.git

...
      - uses: lukasgrunwald/julia-buildpkg@localregistry
        with:
          localregistry: >- # Collect URL's into space seperated string
            https://github.com/lukasgrunwald/CondMatRegistry.git
            https://github.com/HolyLab/HolyLabRegistry.git
          token: ${{ secrets.GITHUB_TOKEN }} # Automatically generated token
...

Option to add local registries to build process by specifying their url (https). Authentication to the repos  via user GitHub token.
@lukasgrunwald lukasgrunwald requested a review from a team as a code owner November 2, 2023 14:52
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@SaschaMann
Copy link
Member

Thanks!

Could you add the example to the README please?

I'm not sure about the input interface of >-. I've rarely seen that being used in workflows and I'm not sure most people are aware of its existance. If they copy and paste it, that's fine, but perhaps there's a more common way using |? That's how e.g. actions/cache handles similar list-like inputs.

Provide multiple remotes separated with |
Add example to ReadMe
Support for private repos/packages with SSH protocol
@lukasgrunwald
Copy link
Contributor Author

Hey @SaschaMann,
I added an example to the ReadMe and updated the interface to use "|". Additionally I dropped the token input option, since this is probably better set by the user in -actions/checkout@v4 anyway. Instead I added the git_cli input, which sets JULIA_PKG_USE_CLI_GIT = git_cli, giving the user the option to control the git setup used by Pkg.

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
@SaschaMann
Copy link
Member

Thank you! Some minor notes but then it's ready to be merged :)

lukasgrunwald and others added 3 commits November 7, 2023 08:33
Co-authored-by: Sascha Mann <git@mail.saschamann.eu>
Co-authored-by: Sascha Mann <git@mail.saschamann.eu>
action.yml Outdated Show resolved Hide resolved
@SaschaMann
Copy link
Member

Thank you!

@SaschaMann SaschaMann merged commit 5484b0e into julia-actions:main Nov 8, 2023
30 checks passed
@DilumAluthge
Copy link
Member

@SaschaMann It looks like this will override a value of JULIA_PKG_USE_CLI_GIT set earlier in the workflow file by the user. Is this intentional?

IMO, if the user has already set the JULIA_PKG_USE_CLI_GIT environment variable, and they don't provide the git_cli input to this action, then we should respect the environment variable set by the user.

@DilumAluthge
Copy link
Member

IMO, if the user has already set the JULIA_PKG_USE_CLI_GIT environment variable, and they don't provide the git_cli input to this action, then we should respect the environment variable set by the user.

#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add option to add additional Pkg registries
3 participants