Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the namespaced collections in the logs db are removed during teardown. #160

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Ensure that the namespaced collections in the logs db are removed during teardown. #160

merged 1 commit into from
Mar 24, 2021

Conversation

achilleasa
Copy link
Contributor

Tests create namespaced (by UUID) capped collections for their logs.
These collections must be removed at teardown; otherwise, their number
will grow without any bound and cause sequential teardowns to take
longer and longer.

Tests create namespaced (by UUID) capped collections for their logs.
These collections must be removed at teardown; otherwise, their number
will grow without any bound and cause sequential teardowns to take
longer and longer.
@achilleasa
Copy link
Contributor Author

!!build!!

Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I question why logs are even in the db. I'm sure they could be better served elsewhere. Interestingly this could be the first chance to remove something from mongo?

@achilleasa
Copy link
Contributor Author

!!build!! (lxd zfs pool for storage was missing; it has been recreated)

@achilleasa
Copy link
Contributor Author

!!build!!

@achilleasa
Copy link
Contributor Author

$$merge$$

@jujubot jujubot merged commit 18c50b0 into juju:master Mar 24, 2021
@achilleasa achilleasa deleted the ensure-namespaced-capped-log-collections-are-removed-during-teardown branch March 24, 2021 18:01
achilleasa added a commit to achilleasa/juju that referenced this pull request Mar 24, 2021
achilleasa added a commit to achilleasa/juju that referenced this pull request Mar 24, 2021
achilleasa added a commit to achilleasa/juju that referenced this pull request Mar 24, 2021
hpidcock pushed a commit to achilleasa/juju that referenced this pull request Mar 24, 2021
jujubot added a commit to juju/juju that referenced this pull request Mar 25, 2021
#12811

This PR bumps the juju/testing dependency to fix a teardown issue that caused sequential tests to take longer and longer to execute.

For more details see juju/testing#160
jujubot added a commit to juju/juju that referenced this pull request Mar 25, 2021
#12810

This PR bumps the `juju/testing` dependency to fix a teardown issue that caused sequential tests to take longer and longer to execute.

For more details see juju/testing#160
jujubot added a commit to juju/juju that referenced this pull request Mar 25, 2021
#12812

This PR bumps the juju/testing dependency to fix a teardown issue that caused sequential tests to take longer and longer to execute.

For more details see juju/testing#160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants