Fix address already in use detection. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgo.go
Outdated
| if strings.Contains(buf.String(), "addr already in use") { | ||
| out := buf.String() | ||
| if strings.Contains(out, "addr already in use") || | ||
| strings.Contains(out, "Address already in use") { |
There was a problem hiding this comment.
What's the chances, strings.Contains(out, "already in use") would be a better fit?
There was a problem hiding this comment.
Yeah good point, I thought I should be specific in-case behaviour changed again in Mongo, but it's only for testing.
|
|
jujubot
added a commit
to juju/juju
that referenced
this pull request
Oct 2, 2019
#10669 ## Description of change Update testing package with mongo port in use fix. juju/testing#147 ## QA steps Run the state package unit tests. ## Documentation changes N/A ## Bug reference N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point mongo's address in use error changed. This will fix retry on address in use error.