Allow testing of DoRequest against status code #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleasa
reviewed
Jun 12, 2019
The following changes are required so we can test against the status code along with the error of a http request. Changing this allows us to work with go-1.12 where the changes to the http(s) server when calling https using http now returns a 400 status code instead of malformed garbage. See: https://go-review.googlesource.com/c/go/+/98447/
835b6c0 to
c205979
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are required so we can test against the
status code along with the error of a http request.
Changing this allows us to work with go-1.12 where the changes to
the http(s) server when calling https using http now returns a 400
status code instead of malformed garbage.
See: https://go-review.googlesource.com/c/go/+/98447/