Prefer mongod 3.2 and improve mongod info caching #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2017 14:25
Previously, MongoDB 2.4 (from juju-mongodb) and the system installed MongoDB (2.6) were preferred over MongoDB 3.2 (which is actually used in production).
Cache the MongoDB path alongside the version. Previously there was a small chance that the cached version would not match the mongod version. This also avoid unnecessarily looking up the mongod path all the time.
babbageclunk
approved these changes
Apr 28, 2017
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, MongoDB 2.4 (from juju-mongodb) and the system installed
MongoDB (2.6) were preferred over MongoDB 3.2 (which is actually used
in production).
Cache the MongoDB path alongside the version. Previously there was a
small chance that the cached version would not match the mongod
version. This also avoids unnecessarily looking up the mongod path all
the time.