Pin pip<23.1 and setuptools<67 to allow PEP-440 non compliance #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP-440 is more strict about requirement lines. As an example:
pytz>dev
is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks
building wheelhouses from source (such as the octavia charm). This
patch pins pip and setuptools to the latest versions that will defintely
still allow PEP-440 non-compliant packages to install.
The option --upgrade-buildvenv-core-deps can be used to override this
and will install the latest versions of pip and setuptools available.
Fixes-Bug: juju#652
|
The integration test failure is unrelated to the change; sadly it looks like a networking issue within charmcraft. |
Closed
3 tasks
ajkavanagh
added a commit
to ajkavanagh/charm-tools
that referenced
this pull request
Mar 15, 2023
to allow PEP-440 non compliance. (backported relevant parts from master branch in juju#653) PEP-440 is more strict about requirement lines. As an example: pytz>dev is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks building wheelhouses from source (such as the octavia charm). This patch pins pip and setuptools to the latest versions that will defintely still allow PEP-440 non-compliant packages to install. The option --upgrade-buildvenv-core-deps can be used to override this and will install the latest versions of pip and setuptools available. Fixes-Bug: juju#652
3 tasks
ajkavanagh
added a commit
to ajkavanagh/charm-tools
that referenced
this pull request
Mar 15, 2023
to allow PEP-440 non compliance. (backported relevant parts from master branch in juju#653) PEP-440 is more strict about requirement lines. As an example: pytz>dev is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks building wheelhouses from source (such as the octavia charm). This patch pins pip and setuptools to the latest versions that will defintely still allow PEP-440 non-compliant packages to install. The option --upgrade-buildvenv-core-deps can be used to override this and will install the latest versions of pip and setuptools available. Fixes-Bug: juju#652
javacruft
pushed a commit
that referenced
this pull request
Mar 15, 2023
to allow PEP-440 non compliance. (backported relevant parts from master branch in #653) PEP-440 is more strict about requirement lines. As an example: pytz>dev is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks building wheelhouses from source (such as the octavia charm). This patch pins pip and setuptools to the latest versions that will defintely still allow PEP-440 non-compliant packages to install. The option --upgrade-buildvenv-core-deps can be used to override this and will install the latest versions of pip and setuptools available. Fixes-Bug: #652
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP-440 is more strict about requirement lines. As an example:
is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks building wheelhouses from source (such as the octavia charm). This patch pins pip and setuptools to the latest versions that will defintely still allow PEP-440 non-compliant packages to install.
The option --upgrade-buildvenv-core-deps can be used to override this and will install the latest versions of pip and setuptools available.
Fixes-Bug: #652
Description of change
Checklist
make test?