Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 585 broke custom WheelhouseTactic overriding #596

Closed
johnsca opened this issue Jan 28, 2021 · 3 comments
Closed

PR 585 broke custom WheelhouseTactic overriding #596

johnsca opened this issue Jan 28, 2021 · 3 comments
Assignees
@ajkavanagh

Comments

@johnsca
Copy link
Contributor

johnsca commented Jan 28, 2021

This explicit reference to the base WheelhouseTactic from PR #585 broke the ability for layers (specifically caas-base) to override the WheelhouseTactic because it doesn't honor override list. Actually, both of the explicit uses of WheelhouseTactic in that function (i.e., also this one) should be fixed to get the type of the existing_tactic and only fall back to the base class if it doesn't exist.
johnsca added a commit to juju-solutions/layer-caas-base that referenced this issue Jan 28, 2021
@johnsca
Fix charm building to work with new WheelhouseTactic updates
6cf092d 
This fork of the WheelhouseTactic got significantly out of date from the
base, and charm-tools PR #585 broke the tactic override mechanism (see
juju/charm-tools#596). This addresses both by
working around the tactic override issue and bringing the custom tactic
into line with the base by making it a subclass.

Fixes #27
@johnsca johnsca mentioned this issue Jan 28, 2021
Merged
@johnsca johnsca mentioned this issue Jan 28, 2021
Closed
@johnsca
Copy link
Contributor Author

johnsca commented Jan 28, 2021

I've worked around this for now in juju-solutions/layer-caas-base#28 and AFAIK that layer is the only one affected, but this should be fixed properly at some point.

@ajkavanagh
Copy link
Contributor

This is probably fixed by #598; please could you verify? Thanks.

@johnsca
Copy link
Contributor Author

johnsca commented Feb 1, 2021

Fixed by #598

@johnsca johnsca closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajkavanagh ajkavanagh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnsca @ajkavanagh