Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken url in generated hook #59

Closed
kwmonroe opened this issue Dec 3, 2015 · 3 comments
Closed

broken url in generated hook #59

kwmonroe opened this issue Dec 3, 2015 · 3 comments
Milestone

Comments

@kwmonroe
Copy link
Contributor

kwmonroe commented Dec 3, 2015

This puts a broken link in my generated hooks:

https://github.com/juju/charm-tools/blob/master/charmtools/build/tactics.py#L217

The URL from the above line should probably point to here, no?

https://jujucharms.com/docs/stable/authors-charm-building

@marcoceppi
Copy link
Contributor

Yes, since the docs have no clue how to properly redirect rewritten URLs
we're just constantly breaking them.

On Thu, Dec 3, 2015 at 12:59 PM Kevin W Monroe notifications@github.com
wrote:

This puts a broken link in my generated hooks:

https://github.com/juju/charm-tools/blob/master/charmtools/build/tactics.py#L217

The URL from the above line should probably point to here, no?

https://jujucharms.com/docs/stable/authors-charm-building


Reply to this email directly or view it on GitHub
#59.

@kwmonroe
Copy link
Contributor Author

kwmonroe commented Dec 3, 2015

fixed in #60 if you like

@marcoceppi marcoceppi added this to the 1.9.4 milestone Dec 3, 2015
@kwmonroe
Copy link
Contributor Author

kwmonroe commented Dec 3, 2015

closing since #60 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants