Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require Go 1.20+ to build #4334

Merged
merged 2 commits into from
Jan 16, 2024
Merged

require Go 1.20+ to build #4334

merged 2 commits into from
Jan 16, 2024

Conversation

davies
Copy link
Contributor

@davies davies commented Jan 10, 2024

close #4326

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b85645) 55.84% compared to head (fa5a177) 55.86%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4334      +/-   ##
==========================================
+ Coverage   55.84%   55.86%   +0.01%     
==========================================
  Files         153      154       +1     
  Lines       39755    39899     +144     
==========================================
+ Hits        22202    22288      +86     
- Misses      15059    15106      +47     
- Partials     2494     2505      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l0wl3vel
Copy link
Contributor

Hey, thanks for working on this. I have two thing that I am not sure about:

  • The Makefile references https://hub.docker.com/r/juicedata/golang-cross when using make snapshot/make release. Where can I find the source code and pipeline for it and will it also be updated to 1.20?

  • Is there a reason not to go to 1.21, which is the latest stable version?

@davies
Copy link
Contributor Author

davies commented Jan 10, 2024

We prefer old stable (1.20) rather than the latest stable.

The image for release could be updated later.

@stefanb
Copy link
Contributor

stefanb commented Jan 15, 2024

When Go 1.22 is released in February the 1.21 will become the new oldstable.

@davies davies merged commit 3cd0726 into main Jan 16, 2024
26 checks passed
@davies davies deleted the go120 branch January 16, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Go Dependency to 1.20+
3 participants