Remove type: object restriction in empty()
#648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
commented
Jun 12, 2023
| @@ -4477,7 +4474,6 @@ fn derive_schema_with_unit_hashmap() { | |||
| "volumes": { | |||
| "additionalProperties": { | |||
| "additionalProperties": { | |||
| "type": "object", | |||
There was a problem hiding this comment.
I am not sure about this one. To begin with I dont get HashMap<(), ()> because in JSON keys must be strings. https://stackoverflow.com/questions/9304528/why-json-allows-only-string-to-be-a-key
There was a problem hiding this comment.
That was to provide some sort of compatibility for #576 to mitigate a case where additionalProperties key and value is both defined as empty object {} as seen in docker's OpenAPI specification.
There was a problem hiding this comment.
But for compatibility it does not matter whether there actually is type: object or not because it is enough that utoipa parses and compiles the schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #647