Fix preserve_order feature
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes `preserve_order` feature for `utoipa-swagger-ui`. Serde `Value` does not retain the order of elements from original type but reorders them resulting unexpected rendering of specification. This was caused by modifications that allowed external JSON docs to be rendered via `SwaggerUi`. This commit fixes this by keeping the original type and allowing use of `serde_json::Value` by wrapping them internally to a super type.
2fa3322 to
237aa4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
preserve_orderfeature forutoipa-swagger-ui. SerdeValuedoes not retain the order of elements from original type but reorders them resulting unexpected rendering of specification. This was caused by modifications that allowed external JSON docs to be rendered viaSwaggerUi. This commit fixes this by keeping the original type and allowing use ofserde_json::Valueby wrapping them internally to a super type.Fixes #561