Unify component schema tokenization #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, there was 3 separate implementation for component schema tokenization. This was a source of trouble and suboptimal at least. This PR will fix this by combining all existing implementations to single implementation. This helps to keep code DRY and makes it easier to maintain and add more features. Also because of this, now the same logic will be used to create schema for ToSchema schemas, parameters and request/response bodies. This makes parameters and request/response body schemas in par with ToSchema schemas.
5558da7 to
fe8e51b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, there was 3 separate implementation for component schema tokenization. This was a source of trouble and suboptimal at least.
This PR will fix this by combining all existing implementations to single implementation. This helps to keep code DRY and makes it easier to maintain and add more features. Also because of this, now the same logic will be used to create schema for ToSchema schemas, parameters and request/response bodies. This makes parameters and request/response body schemas in par with ToSchema schemas.