Entrega4 #5
Merged
Entrega4 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests Objetivo (NO TERMINADO)
edjus
reviewed
Aug 8, 2021
Comment on lines
+29
to
+30
| // juego.jugar(); | ||
| // this.vista.mostrarInterfazColocacion(juego, juego.obtenerJugadorActual(), juego.obtenerSiguienteJugador(), juego.obtenerJugadorJugando().color(), juego.cantidadEjercitosDisponibles()); |
edjus
reviewed
Aug 8, 2021
Comment on lines
+24
to
+32
| @Override | ||
| public void AtacarCon(Jugador jugadorActual, Pais atacante, Pais defensor) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void transferirEjercitos(Jugador jugadorActual, Pais aliado1, Pais aliado2, int cantidadEjercitos) { | ||
|
|
||
| } |
There was a problem hiding this comment.
Hay varios mensajes que no hacen nada, es por que la interfaz "obliga" a que tenga esos métodos, síntoma de una violación al principio de segregación de interfaces. La solución es dividir la interface grande y usarlo según necesidad (se puede implementar más de una interfaz)
edjus
reviewed
Aug 8, 2021
Comment on lines
+90
to
+115
| if (this.jugador == null) return; | ||
|
|
||
| for (String c : this.continentesAOcupar) { | ||
| if (obj1) | ||
| obj1 = (juego.obtenerTablero().obtenerCantidadPaisesDeContinente(c) == | ||
| juego.obtenerTablero().obtenerCantidadPaisesJugadorEnContinente(this.jugador, c)); | ||
| } | ||
|
|
||
| for (Map.Entry<String, Integer> entry : continentesYCantidades.entrySet()) { | ||
| String continente = entry.getKey(); | ||
| Integer cantidad = entry.getValue(); | ||
| if (obj2) | ||
| obj2 = (cantidad <= juego.obtenerTablero().obtenerCantidadPaisesJugadorEnContinente(this.jugador, continente)); | ||
| } | ||
|
|
||
| if (this.limitrofes > 0){ | ||
| for (Pais unPais : juego.obtenerTablero().obtenerPaises()) { | ||
| if (unPais.perteneceA(this.jugador)){ | ||
| int cantidadLimitrofesOcupados = 0; | ||
| for (Pais otroPais : unPais.obtenerLimitrofes() ) { | ||
| if (otroPais.perteneceA(this.jugador)) cantidadLimitrofesOcupados++; | ||
| } | ||
| if (obj3) obj3 = cantidadLimitrofesOcupados >= this.limitrofes; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Quedó algo dificl de leer el código, se podría usar exract method para hacer el código más legible
edjus
approved these changes
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.