Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subnet routers #811

Merged
merged 3 commits into from
Sep 18, 2022
Merged

Fix subnet routers #811

merged 3 commits into from
Sep 18, 2022

Conversation

kradalby
Copy link
Collaborator

This PR fixes (slightly hacky) an issue where subnet routers dont work as we dont pass the PrimaryRoutes parameter.

Signed-off-by: Kristoffer Dalby kristoffer@dalby.cc

Signed-off-by: Kristoffer Dalby <kristoffer@dalby.cc>
Signed-off-by: Kristoffer Dalby <kristoffer@dalby.cc>
Signed-off-by: Kristoffer Dalby <kristoffer@dalby.cc>
@kradalby kradalby marked this pull request as ready for review September 18, 2022 10:15
@kradalby kradalby requested a review from juanfont as a code owner September 18, 2022 10:15
Copy link
Owner

@juanfont juanfont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juanfont juanfont merged commit 42ef71b into juanfont:main Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants