[Bug] Tailscale HEAD (1eaad7d3d) is broken in integration tests #2164
Labels
Milestone
Comments
kradalby
added a commit
to kradalby/headscale
that referenced
this issue
Oct 3, 2024
tailscale/tailscale@1eaad7d broke our reauth test as it makes the client retry with https/443 if it reconnects within 2 minutes. This commit fixes this by running the test as a two part, - with https, to confirm instant reconnect works - with http, and a 3 min wait, to check that it work without. The change is not a general consern as headscale in prod is ran with https. Updates juanfont#2164 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
that referenced
this issue
Oct 3, 2024
* make reauth test compat with tailscale head tailscale/tailscale@1eaad7d broke our reauth test as it makes the client retry with https/443 if it reconnects within 2 minutes. This commit fixes this by running the test as a two part, - with https, to confirm instant reconnect works - with http, and a 3 min wait, to check that it work without. The change is not a general consern as headscale in prod is ran with https. Updates #2164 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> * sort test for stable order Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --------- Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
|
This is fixed, but we should probably document that people should really really use HTTPS. |
|
The error at hand will only occur if you have an headscale running on http, not answering on 443, and the client tries to reconnect/reauth within 2 minutes. If it reconnects after 2 minutes, it should be fine. |
nblock
added a commit
to nblock/headscale
that referenced
this issue
Oct 8, 2024
nblock
added a commit
to nblock/headscale
that referenced
this issue
Oct 9, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
Reauthentication is broken in integration tests for Tailscale clients built from HEAD due to tailscale/tailscale@1eaad7d.
It looks like the commit make fast reconnects force them to use 443, so it should not affect users as long as they use HTTPS.
The solution is likely to document that you more or less need to run HTTPS and to make integration tests that reauth is served over 443.
The text was updated successfully, but these errors were encountered: