Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Actions CI success rate at 1st attempt #53

Merged
merged 16 commits into from
Jan 17, 2024
Merged

Conversation

juanep97
Copy link
Owner

No description provided.

@juanep97
Copy link
Owner Author

juanep97 commented Dec 1, 2023

I think we are going to need to go on the self-hosted runner route @morcuended. Atm, test passing depend a lot on random factors... and on multiples attempts. Not really continuous integration if you have to stop and check that the tests pass at three times at 30min intervals. I reopen #19 .

@morcuended
Copy link
Collaborator

Sure, let's explore that path.

@juanep97 juanep97 changed the title Improve Actions CI success rate at 1st attempt using cache Improve Actions CI success rate at 1st attempt Jan 15, 2024
@juanep97
Copy link
Owner Author

It seems that running one test at a time with -s (single thread in httpdirfs) works. So it might be a limitation of the astrometry index files archive.

@juanep97 juanep97 requested a review from morcuended January 16, 2024 15:15
@juanep97
Copy link
Owner Author

juanep97 commented Jan 16, 2024

Okey, I would say merge since it seems it improves the success rate at first attempt. Checks take more time with httpdirfs -s and max-parallel: 1, but it's better than failing almost every time. The definitive solution is probably a self-hosted runner.

@juanep97 juanep97 requested review from morcuended and removed request for morcuended January 17, 2024 20:17
@juanep97 juanep97 merged commit e52ad09 into main Jan 17, 2024
2 of 4 checks passed
@juanep97 juanep97 deleted the try_actions_cache branch January 17, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants