Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action to add calibrators from PanSTARRS #142

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Action to add calibrators from PanSTARRS #142

merged 8 commits into from
Oct 8, 2024

Conversation

juanep97
Copy link
Owner

@juanep97 juanep97 commented Oct 7, 2024

This PR adds an action to the AstroSource admin for automatically adding calibrators from PanSTARRS.

imagen

@juanep97 juanep97 added the enhancement New feature or request label Oct 7, 2024
@juanep97 juanep97 requested review from morcuended and joteros October 7, 2024 02:37
@juanep97 juanep97 changed the title Action to add calibrators from PANSTARRS Action to add calibrators from PanSTARRS Oct 7, 2024
Copy link
Collaborator

@joteros joteros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ApMag instead of PSFMag
Set condition on the number of observations of each star, ApMagNpt>=5
Set condition on the ApMagStd<0.01

If with those conditions, we cannot find stars, then relax in a second step iteration those for ApMagNpt and ApMagStd

@juanep97 juanep97 requested a review from joteros October 8, 2024 00:11
@juanep97
Copy link
Owner Author

juanep97 commented Oct 8, 2024

@joteros what do you think of those constraints? I think they are a reasonable minimum. Then we just take the top 10 results, by number of observations.

@joteros joteros closed this Oct 8, 2024
Copy link
Collaborator

@joteros joteros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I usually use as minimum magnitude allowed 17 instead of 16, but this is a minor change.
At some point we should add a second iteration search in case the search does not find any star in the FoV, relaxing a bit the criteria (it happened to me a couple of times), increasing the Std threshold, lowering the minimum magnitude and the number of observations required, but this can be done afterwards.

@morcuended morcuended reopened this Oct 8, 2024
iop4admin/modeladmins/astrosource.py Outdated Show resolved Hide resolved
iop4admin/modeladmins/astrosource.py Outdated Show resolved Hide resolved
iop4admin/modeladmins/astrosource.py Show resolved Hide resolved
iop4admin/modeladmins/astrosource.py Show resolved Hide resolved
@juanep97 juanep97 requested review from morcuended and joteros October 8, 2024 12:14
Repository owner deleted a comment from joteros Oct 8, 2024
@juanep97
Copy link
Owner Author

juanep97 commented Oct 8, 2024

Looks good to me. I usually use as minimum magnitude allowed 17 instead of 16, but this is a minor change. At some point we should add a second iteration search in case the search does not find any star in the FoV, relaxing a bit the criteria (it happened to me a couple of times), increasing the Std threshold, lowering the minimum magnitude and the number of observations required, but this can be done afterwards.

I am hesitant to perform this automatic lowering of the quality constraints, since the user would not know about this and would have no choice, at least through this GUI (if we added an interactive tab for it, perhaps). Another option would be to add two different actions, with two different sets of constraints (e.g. "Automatically add field stars from PanSTARRS" and "Automatically add field stars from PanSTARRS (relaxed)").

@joteros
Copy link
Collaborator

joteros commented Oct 8, 2024

Looks good to me. I usually use as minimum magnitude allowed 17 instead of 16, but this is a minor change. At some point we should add a second iteration search in case the search does not find any star in the FoV, relaxing a bit the criteria (it happened to me a couple of times), increasing the Std threshold, lowering the minimum magnitude and the number of observations required, but this can be done afterwards.

I am hesitant to perform this automatic lowering of the quality constraints, since the user would not know about this and would have no choice, at least through this GUI (if we added an interactive tab for it, perhaps). Another option would be to add two different actions, with two different sets of constraints (e.g. "Automatically add field stars from PanSTARRS" and "Automatically add field stars from PanSTARRS (relaxed)").

Sounds like a good solution. In any case, as I said this can be implemented (and even refined) afterwards, and my expectation is that it won't happen too often

@juanep97 juanep97 merged commit c75a487 into main Oct 8, 2024
5 checks passed
@juanep97 juanep97 deleted the auto_panstarrs branch December 17, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate the search for calibrators for new sources using PanSTARRS catalog
3 participants