Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iop4.py: enable recomputing results by astrosource #105

Merged
merged 2 commits into from
Nov 13, 2024
Merged

iop4.py: enable recomputing results by astrosource #105

merged 2 commits into from
Nov 13, 2024

Conversation

juanep97
Copy link
Owner

@juanep97 juanep97 commented May 6, 2024 •
edited
Loading

  • Enables selecting files by source (in between given dates) and recomputing the results.

@juanep97 juanep97 requested a review from morcuended May 6, 2024 12:22
@juanep97 juanep97 added enhancement New feature or request maintenance labels May 6, 2024
morcuended
morcuended requested changes May 6, 2024
View reviewed changes
iop4lib/iop4.py Outdated Show resolved Hide resolved
iop4lib/iop4.py Outdated Show resolved Hide resolved
iop4lib/iop4.py
@@ -94,6 +94,51 @@ def process_epochs(epochname_list: Iterable[str], force_rebuild: bool, check_rem
logger.info("Done.")


def process_astrosource(args):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the function name is quite descriptive, I would add a docstring describing it, maybe with some more detailed Notes as well with the different things it can do and args combinations (retry, recompute, etc).

iop4lib/iop4.py Outdated Show resolved Hide resolved
iop4lib/iop4.py Show resolved Hide resolved
iop4lib/iop4.py Show resolved Hide resolved
@juanep97 juanep97 marked this pull request as draft May 9, 2024 14:45
@morcuended morcuended mentioned this pull request May 9, 2024
Merged
@juanep97
Copy link
Owner Author

juanep97 commented May 9, 2024 •
edited
Loading 

        for redf in redfL:
            redf.compute_photometry()
            redf.compute_polarimetry()

(Re)computing polarimetry results can not be done only from a single reduced file. Polarimetry groups need to be re-computed possibly, and then the polarimetric results need to be computed for the whole group.

@juanep97 juanep97 added the wontfix This will not be worked on label Jun 9, 2024
@juanep97 juanep97 force-pushed the main branch 4 times, most recently from a3b9847 to 5133fea Compare October 29, 2024 17:18
@juanep97 juanep97 force-pushed the allow_select_astrosource branch from fdfc82c to 3c4c09b Compare November 3, 2024 03:38
@juanep97 juanep97 removed the wontfix This will not be worked on label Nov 3, 2024
@juanep97 juanep97 requested a review from morcuended November 3, 2024 03:40
@juanep97 juanep97 marked this pull request as ready for review November 4, 2024 02:14
@juanep97 juanep97 changed the title iop4.py: allow select by astrosource iop4.py: enable recompute results by astrosource Nov 13, 2024
@juanep97 juanep97 changed the title iop4.py: enable recompute results by astrosource iop4.py: enable recomputing results by astrosource Nov 13, 2024
@juanep97 juanep97 merged commit 31e6dc0 into main Nov 13, 2024
5 checks passed
@juanep97 juanep97 deleted the allow_select_astrosource branch December 17, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morcuended morcuended Awaiting requested review from morcuended

Assignees
No one assigned
Labels
enhancement New feature or request maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanep97 @morcuended