Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow icmp firewall rules in starcluster configuration #510

Merged
merged 2 commits into from
Mar 13, 2015
Merged

allow icmp firewall rules in starcluster configuration #510

merged 2 commits into from
Mar 13, 2015

Conversation

pescobar
Copy link

@pescobar pescobar commented Mar 9, 2015

Boto docs says that rules for icmp protocol must use port=-1
http://boto.readthedocs.org/en/latest/security_groups.html

Now starcluster doesn't allow to do this. This patch should fix it and allow to add a a rule like this in the starcluster configuration:

[permission all-icmp-internal]
IP_PROTOCOL = icmp
FROM_PORT = -1
TO_PORT = -1
CIDR_IP = 192.168.1.0/24

@pescobar pescobar mentioned this pull request Mar 9, 2015
Open
jtriley added a commit that referenced this pull request Mar 13, 2015
@jtriley
Merge pull request #510 from pescobar/fix_icmp
5250489 
allow icmp firewall rules in starcluster configuration
@jtriley jtriley merged commit 5250489 into jtriley:develop Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pescobar @jtriley