Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use merge=union to reduce CHANGELOG conflicts #373

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

SR4ven
Copy link
Collaborator

@SR4ven SR4ven commented Jan 20, 2020

Whenever two PRs change the same line of the changelog and one gets merged, the other one is stuck in a merge conflict.

Setting the merge strategy to union will fix this. The only downside is that the order of the lines might not be chronological, which shouldn't be a problem as we usually reorder the lines before a release anyways.

Sadly this will only affect local merges as GitHub still doesn't read the .gitattributes file. Strangely GitLab does support this.
isaacs/github#487
olivierlacan/keep-a-changelog#56

@starek4
Copy link
Contributor

starek4 commented Feb 14, 2020

As this change affects only CHANGELOG.rst, I believe we are free to merge it. The chronological order is not important to me in the changelog.

@SR4ven SR4ven merged commit 493ea65 into jtpereyda:master Feb 16, 2020
@SR4ven SR4ven deleted the merge_union branch February 16, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants