Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$pad function to truncate fractional part of numeric argument #729

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

andrew-coleman
Copy link
Member

Truncating the fractional part of the argument is consistent with the behaviour of other functions expecting integer arguments (e.g. substring)

Resolves #717

Signed-off-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
Copy link
Member

@mattbaileyuk mattbaileyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattbaileyuk mattbaileyuk merged commit 09dba37 into master Jan 14, 2025
8 checks passed
@mattbaileyuk mattbaileyuk deleted the pad branch January 14, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$pad Function With Non-Integer Width Results in Uncaught RangeError
2 participants