Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in the missing check that patternProperties are regexen. #704

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Add in the missing check that patternProperties are regexen. #704

merged 1 commit into from
Jan 7, 2019

Conversation

Julian
Copy link
Member

@Julian Julian commented Jan 6, 2019

This seems to already appear in Draft 7.

@Julian
Add in the missing check that patternProperties are regexen.
c97da08 
This seems to already appear in Draft 7.
@Julian Julian requested a review from handrews January 6, 2019 10:04
@Julian
Copy link
Member Author

Julian commented Jan 7, 2019

Thanks!

@Julian Julian merged commit 59ed5f6 into draft-06 Jan 7, 2019
@Relequestual Relequestual deleted the propertyPatterns branch May 27, 2019 18:48
Relequestual added a commit to json-schema-org/json-schema-org.github.io that referenced this pull request Oct 5, 2020
@Relequestual
Fixes #357
1ca645f 
Update draft-6 meta-schema as per latest fix: json-schema-org/json-schema-spec#704
@Relequestual Relequestual mentioned this pull request Oct 5, 2020
Merged
@Relequestual
Copy link
Member

Relequestual commented Oct 5, 2020 •
edited
Loading

Given format: 'regex' isn't actually in draft-06, should this have been merged?

I notice that the draft-07 changelog says format: 'regex' was removed by mistake previously.
It was in draft-03, but not in draft-04, and not added back again till draft-07.

@Relequestual Relequestual mentioned this pull request Oct 5, 2020
Closed
@auspicacious auspicacious mentioned this pull request Sep 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handrews handrews handrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julian @Relequestual @handrews