Skip to content

Commit

Permalink
👌Simplify the fix as per reviewer suggestions
Browse files Browse the repository at this point in the history
This is possible since Parameter implements __float__
  • Loading branch information
jsnel committed Jan 27, 2024
1 parent 91fde44 commit 3490e52
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions glotaran/builtin/items/activation/gaussian.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from glotaran.model.errors import ItemIssue
from glotaran.model.item import Attribute
from glotaran.model.item import ParameterType
from glotaran.parameter.parameter import Parameter

if TYPE_CHECKING:
from glotaran.parameter import Parameters
Expand Down Expand Up @@ -172,9 +171,7 @@ def parameters(

scales = self.scale or [1.0] * nr_gaussians
backsweep = self.backsweep is not None
backsweep_period = self.backsweep if backsweep else 0
if isinstance(backsweep_period, Parameter):
backsweep_period = backsweep_period.value
backsweep_period = float(self.backsweep) if backsweep else 0

parameters: list[GaussianActivationParameters] = [
GaussianActivationParameters(
Expand Down

0 comments on commit 3490e52

Please sign in to comment.