-
Notifications
You must be signed in to change notification settings - Fork 509
jscs .
hangs when running on Node 0.11 in Windows
#703
Comments
Test case:
Tested on Windows 7 x64 Ultimate, Node 0.11.14, jscs 1.7.3 |
Well, we do not support node 0.11 no one does i suppose. |
@markelog I have seen some packages that do test against Node 0.11. |
@markelog seeing as Node 0.11 will be the base for 0.12, I believe it makes sense to test against it. Most packages I use work just fine on Node 0.11. Most of the time, it only takes very small changes in order to be compatible with 0.11. I can try to triage this issue when I have a bit more of free time. |
@UltCombo, thanks for contributing. If you could look into this issue, it would be very helpful. I don't have a windows box to test on :-\ |
It works fine when I add a |
Weirdly enough, the |
Found the issue here.
This is probably a Node issue though, I recall seeing some discussion about drive letter casing, I'll have to check on their repository to see if there has been a consensus. |
Great job! Sounds like a doozy
|
The issue could be worked around here by using Minimatch's However, it looks like |
@UltCombo riiight, that is why it's not pragmatic to test your stuff on unstable platform, since most of those inconsistencies will disappear in stable release. If you want to run your code on .11 that is one thing (if your thing is doubling your work efforts) but you don't have to use jscs with .11 just use it with .10 for code your written for .11. |
Not when you don't have a choice. There are quite a handful of projects which are only compatible with >= 0.11.
Sure thing, however, I believe it is rather cumbersome to setup tests to have jscs run on .10 and unit tests on .11, in both local development and Travis. Anyway, this issue is workable around on my end so no worries. I'll bring this topic to the Node repository which should be the proper place for this issue, and perhaps suggest an workaround on Minimatch. |
Looks like a really localized issue. Basically, the command:
Hangs and never finishes. Note that it is only reproducible with Node 0.11.x on Windows. It works fine with Node 0.11 on Unix-based systems, and it also works fine with Node 0.10 on Windows.
The text was updated successfully, but these errors were encountered: