Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup rule configuration asserts and add tests #44

Merged
merged 1 commit into from
Nov 10, 2014
Merged

fixup rule configuration asserts and add tests #44

merged 1 commit into from
Nov 10, 2014

Conversation

qfox
Copy link
Member

@qfox qfox commented Nov 10, 2014

  • fixup bug in checkOption method (not it works)
  • add tests for all rules

Fixes #23

fixup rule configuration asserts and add tests
ef018b9 
- fixup bug in checkOption method (not it works)
- add tests for all rules

Fixes #23
Closes #44
qfox added a commit that referenced this pull request Nov 10, 2014
@qfox
Merge pull request #44 from zxqfox/hotfix/invalid-configuration-shoul…
955d3ac 
…d-throws

fixup rule configuration asserts and add tests
@qfox qfox merged commit 955d3ac into jscs-dev:master Nov 10, 2014
@qfox qfox deleted the hotfix/invalid-configuration-should-throws branch November 10, 2014 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check configuration values on init
1 participant
@qfox