Merge pull request #38 from zxqfox/hotfix/missing-jsdoc-bugs

bugs with missing jsdoc blocks
jscs-dev · Nov 10, 2014 · e705052 · e705052
2 parents f5182b6 + 5cf667c
commit e705052
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 1 deletion.
diff --git a/lib/rules/validate-jsdoc/check-param-names.js b/lib/rules/validate-jsdoc/check-param-names.js
@@ -10,6 +10,10 @@ module.exports.options = {
  * @param {Function} err
  */
 function validateCheckParamNames(node, err) {
+    if (!node.jsdoc) {
+        return;
+    }
+
     node.jsdoc.iterateByType(['param', 'arg', 'argument'],
         /**
          * tag checker

diff --git a/lib/rules/validate-jsdoc/check-redundant-params.js b/lib/rules/validate-jsdoc/check-redundant-params.js
@@ -10,6 +10,10 @@ module.exports.options = {
  * @param {Function} err
  */
 function validateCheckParamNames(node, err) {
+    if (!node.jsdoc) {
+        return;
+    }
+
     node.jsdoc.iterateByType(['param', 'arg', 'argument'],
         /**
          * tag checker
@@ -18,7 +22,7 @@ function validateCheckParamNames(node, err) {
          */
         function(tag, i) {
             // skip if there is dot in param name (object's inner param)
-            if (tag.name.value.indexOf('.') !== -1) {
+            if (tag.name && tag.name.value.indexOf('.') !== -1) {
                 return;
             }
 

diff --git a/test/lib/rules/validate-jsdoc/check-param-names.js b/test/lib/rules/validate-jsdoc/check-param-names.js
@@ -9,6 +9,13 @@ describe('rules/validate-jsdoc', function () {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should report invalid jsdoc',
                 code: function () {
                     var x = 1;

diff --git a/test/lib/rules/validate-jsdoc/check-redundant-params.js b/test/lib/rules/validate-jsdoc/check-redundant-params.js
@@ -9,6 +9,13 @@ describe('rules/validate-jsdoc', function () {
         checker.cases([
             /* jshint ignore:start */
             {
+                it: 'should not throw',
+                code: function() {
+                    function yay(yey) {
+                    }
+                }
+
+            }, {
                 it: 'should report redundant jsdoc-param for function',
                 errors: 1,
                 code: function () {