-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create empty file if no bytes written to S3 file in 'w' mode #816
Create empty file if no bytes written to S3 file in 'w' mode #816
Conversation
Looks like my remaining build failure is due to extra warnings being thrown on Python 3.8 for |
Why should this be optional? Shouldn't the backend always follow the upstream behavior of |
@jdufresne Completely agree it should not be optional in an ideal world. I was concerned it would be a breaking change though, since that's not how it works right now. If people think it should be standard behavior I'm happy to make it that way (it's easier for me). cc @jschneier |
@jschneier Any chance this can be merged? I love empty files. |
Please remove the setting.
…On Monday, January 27, 2020, John Peloquin ***@***.***> wrote:
@jschneier <https://github.com/jschneier> Any chance this can be merged?
I love empty files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#816?email_source=notifications&email_token=AAREDWFHV3R23GJQ4BWCZETQ74CHDA5CNFSM4KHJNEBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKACWGA#issuecomment-578824984>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAREDWFSTGPWULORX7OJUXLQ74CHDANCNFSM4KHJNEBA>
.
|
@jschneier Thanks for the reply. I removed the setting. Looks like the Python 3.8 build issue is resolved now. |
@jschneier Now that the setting is removed, any chance this can be merged? Thanks! |
This PR adds functionality to
S3Boto3StorageFile
that will create an empty file if no bytes are written to S3 after opening a file inw
mode, similar to howFileSystemStorage
and Python's nativeopen
work.Let me know if I'm missing anything or if you have any questions. Thank you!
Fixes #435