Allow S3Transfer config to be customised #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cc1a82 to
419f2ab
Compare
A typical use for this would be to control number of threads, or even disabling threads. For example, some transfers are unlikely to be faster than the transfer to/from S3, and so triggering threads is unlikely to be helpful. The setting AWS_S3_TRANSFER_CONFIG is used twice so that S3Boto3Storage and S3Boto3StorageFile, which can be used directly in client code, can both be customised.
419f2ab to
8fdb7a1
Compare
|
Superseded by #1280. I guess 4 years later is better than never... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typical use for this would be to control number of threads, or even disabling threads. For example, some transfers are unlikely to be faster than the transfer to/from S3, and so triggering threads is unlikely to be helpful.
The setting AWS_S3_TRANSFER_CONFIG is used twice so that S3Boto3Storage and S3Boto3StorageFile, which can be used directly in client code, can both be customised.