[s3] raise ImproperlyConfigured if no bucket name is set #1313
Conversation
|
This change broke my testing setup in CI. I'm not disputing that this is a correct change to the package, only that it was a breaking change for how I was loose with s3 variable definitions in my CI. A while back I made a choice on this project not to use S3 when running unit tests. On my my local machine, running tests manually, I defined the bucket. But in CI I was setting Looking at it again, I see I've had to make a number of small hacks to handle not using S3 there. With this new error, it seems like maybe its time to clear the cruft and just let CI have at a valid Are people reading / writing to S3 in their unit tests? Could be I'm not configuring django-storages for non-s3 usage in my CI run. |
|
@jschneier Hello, I have same issue as @banagale. ImproperlyConfigured error broke my CI. I fixed it by set random bucket name in my CI, but is there a way to move this check in another place or option to disable this check? |
|
@mike667 Glad I'm not the only one. Can you give more detail on the context of how you're using Also, curious if you have a reason for needing S3 in your CI, is it part of unit testing? This particular issue popped up due to a reliance on the package from a wagtail installation I did recently. |
|
Hi in general I would expect that CI and Test would swap out the backend but I’ll see what I can do. |
I think swapping out the backend for CI and test is the right way to go about it. So, I don't know if a change is needed. The docs clearly say bucket names are required. It could be that adding guidance on config for unit testing in the docs would be enough. Right now there are no results for Unit Tests searching the docs. If helpful, I could file an issue on this and look at providing a PR. |
…)" This reverts commit 9eeb8c3.
|
I am reverting this commit and will release a new version as soon as this and the other pr land. |
Closes #1140