Azure: support user delegation key #1063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that #805 had been merged! Very happy to see it, thank you.
While that has been waiting, I have been running with a variation on the Azure storage code that adds support for user delegation keys. This allows us to hand out URLs after using a managed service identity to authenticate with the blob store, rather than an account key. Once you have set up your Azure resources appropriately, the configuration looks something like this:
Since getting a user delegation key requires use of the
BlobServiceClient
I've also refactored the creation of theContainerClient
ever so slightly to reuse that. I must admit I had my doubts about the value of this refactoring when I came to polish this into an MR and realized that I'd have to fix up the resulting unit test breakage! but I do think it is the cleanest way.