Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for inline snippets #35

Merged
merged 7 commits into from
Mar 14, 2014
Merged

Support for inline snippets #35

merged 7 commits into from
Mar 14, 2014

Conversation

zaggino
Copy link
Collaborator

@zaggino zaggino commented Mar 10, 2014

This fixes issue #15

@tomengland
Copy link

Great suggestion, I was just about to try and make a suggestion to do this, as console log will always insert new line.

@jrowny
Copy link
Owner

jrowny commented Mar 12, 2014

Not sure if it was this pull request or an earlier one, but the current tab spacing is no longer retained for HTML. Seems to be okay in script, but for example, if you do an insert in HTML, it always goes all the way to the left. This may be a completely seperate issue.

@jrowny
Copy link
Owner

jrowny commented Mar 12, 2014

Inline snippets sometimes delete trailing text. In the example below, the text after the snippet is deleted.
testing

@zaggino
Copy link
Collaborator Author

zaggino commented Mar 13, 2014

@jrowny all fixed except the wrong snippet indentation. This issue is caused by old piece of code that was there before my modifications. After insering any snippet, it is indented by CodeMirror.

//indent lines
for (x = 0; x < lines.length; x++) {
    editor._codeMirror.indentLine(pos.line + x);
}

jrowny added a commit that referenced this pull request Mar 14, 2014
Support for inline snippets.
@jrowny jrowny merged commit 58428d5 into master Mar 14, 2014
@jrowny jrowny deleted the issue-15 branch March 14, 2014 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants