Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides settings dialog to configure shortcuts. #34

Merged
merged 2 commits into from
Mar 10, 2014
Merged

Provides settings dialog to configure shortcuts. #34

merged 2 commits into from
Mar 10, 2014

Conversation

zaggino
Copy link
Collaborator

@zaggino zaggino commented Mar 10, 2014

Solves issue #19 as everything is user-configurable now.

@jrowny
Copy link
Owner

jrowny commented Mar 10, 2014

I completed my review. Overall it looks good!

- remove ellipsis
- removed tabs
- horizontal forms
- ok & cancel buttons on the right
@zaggino
Copy link
Collaborator Author

zaggino commented Mar 10, 2014

Fixed all the other stuff except empty default, you can take a look.

jrowny added a commit that referenced this pull request Mar 10, 2014
Provides settings dialog to configure shortcuts.
@jrowny jrowny merged commit 00eff3d into master Mar 10, 2014
@jrowny jrowny deleted the issue-19 branch March 10, 2014 21:12
@jrowny
Copy link
Owner

jrowny commented Mar 10, 2014

Looks good, merged! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants