Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes. I tested it locally test_vm and test_vm_serialization can all pass. CI should be happy now. Two other fixes. The first one is the serialization.
In the second one, I removed the last constant folding pass in memory pass to make test_vm_serialization pass (like MobileNet and ResNet). It actually reveals a problem/bug for VM because with this constant folding we will have:
Then compiler would get stuck here:
https://github.com/apache/incubator-tvm/blob/c936a81dab2b4b4b595d02153a6654b9d4e09cd5/src/relay/backend/vm/compiler.cc#L463
The problem reported by Luis is actually the same, which actually wasn't a bug introduced by the mentioned PR, but it would reveal this problem.