Fix for upgrade with missing journal #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
wren
requested changes
Jan 26, 2020
| "default_hour": 9, | ||
| "timeformat": "%Y-%m-%d %H:%M", | ||
| "linewrap": 80, | ||
| "encrypt": false, |
There was a problem hiding this comment.
Can we add the same tests but for an encrypted journal? Just be sure it works.
There was a problem hiding this comment.
I've added a test for this which is failing, although the actual code works. I'm not certain, but it could be that the output it being piped to stderr which doesn't have an equivalent "the output should contain". Can you take a look? I'll add a step in core.py if so.
wren
added a commit
to wren/jrnl
that referenced
this pull request
Mar 28, 2020
* Fix for upgrade with missing journal * add test, refactor solution * add missing test config Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
wren
added a commit
that referenced
this pull request
Mar 28, 2020
* Fix for upgrade with missing journal * add test, refactor solution * add missing test config Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
wren
added a commit
that referenced
this pull request
Apr 18, 2020
* Fix for upgrade with missing journal * add test, refactor solution * add missing test config Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #690 - if a journal is found to be missing during upgrade the user will be prompted to create it or cancel the upgrade.
Tests depend on #795
Checklist