Password confirmation

[pspeter]

Stacked on #705. Rebased on Master.

When creating a new password (using --encrypt), jrnl will now ask you to repeat the password. It will only encrypt it after you entered the same password correctly twice.
I've read some people complaining about permanently encrypting their journal because they mistyped their password, this should prevent that.

This does not work during the install yet, but will in #708.

Fixes #481.

Checklist

• The code change is tested and works locally.
• Tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?

[wren]

v2.1.1 is getting a bit big, so I'm moving this to v2.1.2.

[wren]

@pspeter Can you add some non-happy-path tests? Like what happens if you mistype the password on the second try?

[pspeter]

@wren Done 👍

[wren]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.