Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create templates for issues and pull requests #679

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Create templates for issues and pull requests #679

merged 1 commit into from
Oct 28, 2019

Conversation

C0DK
Copy link

@C0DK C0DK commented Oct 13, 2019 •
edited
Loading

I saw that you lacked templates for the different github features (pullrequests and issues) so i wanted to quickly help out as i love the service. I might have made a few typos, but i hope they work. Please supply any corrections and i'll gladly change the PR 😃

It solves issue #668

Checklist

sadly all irrelevant

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@C0DK C0DK force-pushed the master branch 2 times, most recently from 4434f92 to 03205ff Compare October 14, 2019 20:24
@wren wren added 📌 This can't go stale documentation Improvements or additions to documentation labels Oct 15, 2019
@wren wren added this to the v2.1 - Pipeline Streamline milestone Oct 15, 2019
@wren
Copy link
Member

wren commented Oct 15, 2019

Thank you! I've been meaning to put this in place. I have time set apart this weekend to work on jrnl, so I'll review this then.

@C0DK
Copy link
Author

C0DK commented Oct 16, 2019

Thank you! I've been meaning to put this in place. I have time set apart this weekend to work on jrnl, so I'll review this then.

I really love jrnl - so i wanted to contribute somehow, and that felt like an easy place to start :)

maebert
maebert reviewed Oct 23, 2019
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated

* **Please tell us about your environment:**
- Jrnl version: (run `jrnl -v`)
- Python version: (run `python -V`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that jrnl might be using a different python than the one that python points to. The quickest way to find it is to run head -1 `which jrnl` , but we should probably just print this when running jrnl -v instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that'd be a thing jrnl -v should print. i.e: jrnl version 1.9.8 (running on python3.8.1) kindof.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this to the jrnl -v output now :)

@C0DK
Copy link
Author

C0DK commented Oct 24, 2019

So I've changed the output of version, so it's more fulfilling - But the test cases checking that fails. so I don't know if you want to accept the new format and with it change the test case

@wren
Copy link
Member

wren commented Oct 24, 2019

@C0DK , can you please separate the version thing from the rest of the PR. We're trying to have one fix per PR to facilitate code review, and scheduling feature and bug releases.

@C0DK
Copy link
Author

C0DK commented Oct 26, 2019

@wren will do :) sorry.

wren
wren approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wren
Copy link
Member

wren commented Oct 28, 2019

@C0DK Thanks, again! I'd be happy to take a look at the version thing in a separate PR, if you want to resubmit it.

@wren wren merged commit 53677a9 into jrnl-org:master Oct 28, 2019
@C0DK C0DK mentioned this pull request Oct 28, 2019
Closed
7 tasks
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maebert maebert maebert left review comments

@wren wren wren approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation 🔒 Outdated 📌 This can't go stale
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@C0DK @wren @maebert