Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issues around unreadable dates to allow markdown footnotes and prevent accidental deletion #623

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Resolve issues around unreadable dates to allow markdown footnotes and prevent accidental deletion #623

merged 1 commit into from
Jul 20, 2019

Conversation

micahellison
Copy link
Member

This adds a few changes to the way jrnl reads dates and entries:

  • Assume any value in brackets but 6 characters or less isn't a date but is instead part of the current entry. This is useful for markdown footnotes as mentioned in 2.0-rc2: ValueError in strftime() #614
  • If a journal has only unreadable dates, assume that it's one entry (instead of ignoring its contents completely, which could lead to deletion in future jrnl calls)

@wren wren added this to the v2.0-rc3 milestone Jul 20, 2019
@wren wren added the bug Something isn't working label Jul 20, 2019
wren
wren approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@wren wren merged commit 5443743 into jrnl-org:master Jul 20, 2019
@notbalanced notbalanced mentioned this pull request Sep 25, 2019
Closed
@wren wren changed the title [GH-614] resolving issues around unreadable dates [GH-614] resolve issues around unreadable dates Jan 10, 2020
@micahellison micahellison changed the title [GH-614] resolve issues around unreadable dates Resolve issues around unreadable dates to allow markdown footnotes and prevent accidental deletion Jan 11, 2020
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
bug Something isn't working 🔒 Outdated
Projects
None yet
Milestone
v2.0-rc3
Development

Successfully merging this pull request may close these issues.
2 participants
@micahellison @wren