Correct issue #259, also fix issue with specifying DayOne journals in install #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
slow clap Thank you, sir! |
maebert
added a commit
that referenced
this pull request
Jan 11, 2015
Correct issue #259, also fix issue with specifying DayOne journals in install
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues with DayOne compatibility:
Duplicate entries when using Linux to edit DayOne journals
Python's uuid.uuid1 returns a lowercase uuid string by default, but DayOne
saves it's filenames using an uppercase UUID by default.
On OS X (and I believe windows) filesystems case is preserved, but not
enforced, so using jrnl on a DayOne jrnl file works as expected. On Linux
however, filesystem case is strictly enforced. As a result when jrnl and DayOne
interact duplicate files get created--one copy with uppercase UUIDs and one
with lowercase.
Installer doesn't finish if you point it an an existing DayOne journal
If you specify the top-level diectory of your DayOne journal during install
jrnl dies because it is expecting a file.