Update version key in config file after version changes #1646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1638
As mentioned in #1638 the reference states:
jrnl now checks if the version in the config file differs from the current version, and if so, updates it. And I also added a BDD test for this functionality.
Side question: While working on this, I saw no BDD test for adding missing keys in the config. But for some reason the message 'Configuration updated to newest version at' prints when testing in 'poetry shell', but not while running in a test. Do BDD tests automatically fill in the config fields that aren't there yet?
Checklist
for the same issue.