-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed error related to display_format in config file for some values #1495
Conversation
Actually, it looks like this clobbers the |
Now _display_search_results tries to source the export arg from the config file before dispaying search results.
30d0902
to
369142d
Compare
Okay, I had to change it to evaluate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just updated the unit test to fix the tags issue you were running into.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just added a BDD test in case of regressions.
Checklist
for the same issue.
Basically what was happening was that using
display_format: pretty
ordisplay_format: short
in your config file would cause an error. The reason for this was that even though those arguments were handled correctly they were sourced from the config file after those if statements had already been skipped over.Now
_display_search_results
tries to source thedisplay_format
value from the config file if theexport
arg is empty before displaying search results. This is a small change so I didn't include any tests. Let me know if you think they are necessary and I'd be happy to add them.Fixes #1263.