Yaml export errors now don't show stack trace #1449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
for the same issue.
This is a fix for the bug mentioned in #1227 related to failed YAML exports showing the stack trace along with an error message. Now it just shows the error message.
Instead of printing an error message and returning
none
, I changed it to throw aRuntimeError
. The advantage of this is that the calling function doesn't throw aTypeError
when it gets back anone
value instead of astring
. It also gives us the opportunity to clean up the file that was open.Closes #1227.