Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full Python version for GitHub Actions cache key #1373

Merged

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Nov 13, 2021

We keep running into stale cache issues when this happens:

  • Someone opens a PR
  • Python releases a new patch version (like from 3.9.7 to 3.9.8)
  • The next time tests run on that PR, they crash because they're have references to the older patch version

This should fix the issue by grabbing the full python --version output such as "Python 3.9.8" and using that as part of the cache key.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@micahellison micahellison added the build Issues related to the build pipeline label Nov 13, 2021
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🧨

@micahellison micahellison merged commit 5e45f30 into jrnl-org:develop Nov 13, 2021
@micahellison micahellison deleted the cache-full-python-version branch November 13, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants