Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.10 support #1271

Merged
merged 16 commits into from
Jul 10, 2021
Merged

Add Python 3.10 support #1271

merged 16 commits into from
Jul 10, 2021

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Jun 24, 2021 •
edited
Loading

Fixes #1270, if all the tests pass on all platforms.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@musicinmybrain
Copy link
Contributor

musicinmybrain commented Jun 27, 2021 •
edited
Loading

I managed to reproduce the CI failure in an Ubuntu VM. I also found a report at https://bugzilla.redhat.com/show_bug.cgi?id=1970361, the corresponding upstream bug (python-poetry/poetry#3897), and the PR that fixed the bug: python-poetry/poetry#3895. The PR was merged into master, but it seems it has not been backported to the 1.1 branch, so the bug is still present in the latest release of poetry.

@wren
Copy link
Member

wren commented Jun 27, 2021

In that case, we could probably install poetry 1.2.0a1 to get through this. I tested locally, and that seems to fix the error.

I'm hesitant to use an alpha build for our entire pipeline, though, but I'd be okay with doing it just for the python 3.10-dev tests.

micahellison and others added 5 commits July 3, 2021 16:05
wren added 5 commits July 3, 2021 16:12
@wren
fix syntax error
13f47c7
@wren
rename steps to make more sense
11efc62
@wren
remove dev dependency that breaks with python 3.10
2d420b2
@wren
update tests
55bac96
@wren
Change test dependencies for minimal breakage on python 3.10
701758e 
- loosen the test dep requirements (so we get warned about these
  problems sooner)
- add new extras group to provide minimal deps required for testing (we
  don't need to run static analysis again on every version)
@wren
Copy link
Member

wren commented Jul 8, 2021

Well, this isn't great. I ran into python-poetry/poetry#3153 while updating our dependencies. I think we might have to install poetry v1.2.0a1 for all of our tests, or I'm afraid they might not run anymore. I did it and now all of the tests are passing.

Thoughts on using an alpha build for our entire pipeline?

@wren
Revert "test"
f593af6 
This reverts commit 31e5383.
@micahellison micahellison changed the title [WIP] Add Python 3.10 support Add Python 3.10 support Jul 10, 2021
@micahellison micahellison added the build Issues related to the build pipeline label Jul 10, 2021
@micahellison
Copy link
Member Author

Turns out these GitHub Actions failures were a fluke - we reverted and ran again and everything passes.

@micahellison micahellison marked this pull request as ready for review July 10, 2021 19:11
wren
wren approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👩‍⚕️

@micahellison micahellison merged commit 2723e1c into jrnl-org:develop Jul 10, 2021
@micahellison micahellison deleted the python3-10 branch July 10, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.10 support
3 participants
@micahellison @musicinmybrain @wren