Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --version from brew release workflow #1233

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

wren
Copy link
Member

@wren wren commented Apr 24, 2021

Homebrew doesn't like explicitly declaring a version for a formula, prefers to infer it from the url (as mentioned in Homebrew/homebrew-core#67264). This will throw an error on PRs, so this PR removes that part of the workflow.

Homebrew doesn't like explicitly declaring a version for a formula (it
prefers to infer it from the url), and will throw an error on PRs. So,
this removes that part of the workflow.
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahellison micahellison added the build Issues related to the build pipeline label Apr 24, 2021
@micahellison micahellison merged commit 3051271 into jrnl-org:develop Apr 24, 2021
@micahellison micahellison deleted the brew-deploy-fix-4 branch April 24, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants